fix: initialize active order timestamps in api trading flows by marcuspocus · Pull Request #143 · hummingbot/hummingbot-api

marcuspocus · 2026-04-06T16:25:25Z

Summary

Fix active order timestamp handling for API-managed connectors that are not running under a Hummingbot Clock.

This change does two things:

initializes the connector timestamp before buy / sell calls in the API trading flows
makes /trading/orders/active tolerate non-finite timestamps if they still appear on an in-flight order

Context

While validating Hyperliquid perpetual testnet order placement through hummingbot-api, the exchange-side order flow was working, but /trading/orders/active could fail when it tried to serialize a freshly created in-flight order.

The root cause is that API-managed connectors in this stack are not driven by a persistent Hummingbot Clock. In that setup, connector.current_timestamp can still be NaN at order creation time. Since ExchangePyBase.start_tracking_order() copies self.current_timestamp into the new InFlightOrder, the order may be tracked with creation_timestamp = NaN and last_update_timestamp = NaN until the first update arrives.

That makes the active-orders serializer fragile because it attempts to convert those values to datetimes.

Changes

call connector._set_current_timestamp(time.time()) before delegating to connector.buy() / connector.sell() in:
- services/accounts_service.py
- services/trading_service.py
- AccountsService.place_trade(...)
harden _standardize_in_flight_order_response() so non-finite timestamps are returned as None instead of raising during serialization
add focused tests that cover:
- timestamp initialization before order submission
- active-order serialization when timestamps are NaN

Validation

Targeted tests:

/root/hummingbot-stack/.venv-pr/bin/python -m pytest -q test/test_order_timestamp_tracking.py test/test_trading_router.py
result: 6 passed

Manual validation against a local hummingbot-api deployment:

submitted a BUY LIMIT BTC-USD order on hyperliquid_perpetual_testnet
confirmed /trading/orders/active returned 200 with the live order present
confirmed the order could be canceled successfully

Notes

This PR stays narrow:

no connector logic changes
no exchange-specific workaround
no change to historical order storage
only the API-side handling needed to keep active-order tracking consistent for API-managed connectors

update environment to fix pandas issue

update environment.yml

…t_api_to_library (feat) adapt connector initialization

Feat/certs path

Adding multi_grid_strike.py so I can use it with hummingbot-mcp

feat / add multi_grid_strike controller

- matching PR for #7796

Resolved conflict in services/executor_service.py by keeping ExecutorLogCapture import

- Handle LP executor's market structure in executor_service (extracts connector_name/trading_pair from market object instead of direct fields) - Add LP executor example to CreateExecutorRequest schema - Add LP-specific types: LP_EXECUTOR_STATES, LP_EXECUTOR_SIDES, ConnectorPairConfig, LPExecutorConfigSchema, LPExecutorCustomInfo - Update router docstrings with LP executor configuration details - Update /types/available endpoint with better LP executor description Co-Authored-By: Claude Opus 4.5 <[email protected]>

Adds the LP Rebalancer controller for automated LP position management: - Uses total_amount_quote and side for position sizing - Implements KEEP vs REBALANCE logic based on price limits - Supports directional grids with sell/buy price ranges - Auto-rebalances when price moves out of range beyond threshold Co-Authored-By: Claude Opus 4.5 <[email protected]>

Co-Authored-By: Claude Opus 4.5 <[email protected]>

- Update list_controllers to detect both single-file and package-style controllers - Update get_controller to read from both locations - Update create/update controller to write to existing package or create single file - Update delete controller to handle both file and folder deletion - Update load_controller_config_class to try both import paths - Fix lp_rebalancer __init__.py to use relative import - Remove stale lp_manager.py (replaced by lp_rebalancer) Co-Authored-By: Claude Opus 4.5 <[email protected]>

Feat/update hummingbot

- Remove LP-specific types from models/executors.py (duplicates of hummingbot types) - Update LPExecutorConfig to use direct connector_name/trading_pair fields - Simplify executor_service.py by removing LP-specific handling - Sync lp_rebalancer controller with hummingbot version This aligns LP executor with the pattern used by position, grid, and DCA executors, making the API consistent across all executor types. Co-Authored-By: Claude Opus 4.5 <[email protected]>

- Add DEVELOPERS.md with detailed instructions for: - Building hummingbot wheel from custom branches - Building Linux wheels for Docker using containerized builds - Setting up development environment with custom wheels - Troubleshooting common issues (platform mismatch, Python version) - Add environment.docker.yml for Docker builds with local wheel - Add environment.yml.example as template for developers - Update Dockerfile to support custom wheel builds - Add *.whl to .gitignore for local development Co-Authored-By: Claude Opus 4.5 <[email protected]>

- Revert Dockerfile to original (uses PyPI hummingbot) - Add Dockerfile.dev for development builds with custom wheel - Update DEVELOPERS.md to use Dockerfile.dev for custom builds This keeps the main CI/CD pipeline unchanged while enabling developers to test with custom hummingbot branches. Co-Authored-By: Claude Opus 4.5 <[email protected]>

- Add docker-compose.dev.yml that uses hummingbot-api:dev image - Update DEVELOPERS.md with simplified deployment instructions - Enables testing with custom hummingbot branches Tested: lp_executor now shows in available executor types when using development hummingbot wheel. Co-Authored-By: Claude Opus 4.5 <[email protected]>

Document how to deploy bots using development hummingbot images instead of the default :latest tag. Co-Authored-By: Claude Opus 4.5 <[email protected]>

- Add gateway_proxy router (prefix: /gateway-proxy) that forwards requests to Gateway - Fix DELETE requests not forwarding body to Gateway - Keep executors router and lp_executor services from feat/lp-executor - Resolve all merge conflicts in main.py imports and router registration - Fix flake8: blank lines, unused imports, long lines

- Add GatewayLp support in unified_connector_service for gateway connectors (meteora/clmm, raydium/clmm, etc.) that aren't in AllConnectorSettings - Remove candles_config and markets from v2_with_controllers script config to fix compatibility with hummingbot:staging branch - Remove development Docker files (moved to separate workflow) - Fix f-strings without placeholders Co-Authored-By: Claude Opus 4.5 <[email protected]>

- Test GatewayLp import, instantiation, and required methods - Test gateway detection logic in _create_trading_connector - Test script config fix (candles_config/markets removed) - Test LP executor type registration - Integration tests for API endpoints Verifies fixes for: - KeyError: 'meteora/clmm' issue - Staging deployment compatibility Co-Authored-By: Claude Opus 4.5 <[email protected]>

feat: add LP executor support

Closes hummingbot#133 - Prevents recurring "Invalid Ethereum address format" errors by skipping wallets with placeholder values like "ethereum-default-wallet" or "solana-default-wallet" during balance polling. Co-Authored-By: Claude Opus 4.5 <[email protected]>

Added a function to pull the latest Hummingbot Docker image during setup.

Add function to pull Hummingbot Docker image

Co-Authored-By: Claude Opus 4.6 <[email protected]>

(feat) add controller id to executors

david-hummingbot and others added 30 commits September 13, 2025 06:49

Merge pull request hummingbot#77 from hummingbot/fix/pandas-issue

d0e5bef

update environment to fix pandas issue

update environment.yml

68367ab

(feat) adapt connector initialization

ba64227

Merge pull request hummingbot#79 from hummingbot/fix-pandas

bcda91c

update environment.yml

(feat) replate reference to non trading connectors

8dd6625

fix environment issue

758eba6

Merge branch 'main' into feat/adapt_hummingbot_api_to_library

54c0c6b

Merge pull request hummingbot#82 from hummingbot/feat/adapt_hummingbo…

f1c4d5e

…t_api_to_library (feat) adapt connector initialization

(feat) remove refs to certs

a47a3d1

(feat) add controller docs

b4a5ff6

Merge pull request hummingbot#84 from hummingbot/feat/certs_path

5fcc741

Feat/certs path

feat / add multi_grid_strike controller

abf770e

Adding multi_grid_strike.py so I can use it with hummingbot-mcp

Merge pull request hummingbot#85 from hummingbot/add-multi_grid_strike

8758343

feat / add multi_grid_strike controller

(feat) add controller docs

b3ca232

(feat) ignore gateway files

da80e55

(feat) add passphrase for gateway in env

5ca7d25

(feat) add gatewya models

15bd8e1

(feat) add gateway service

13bd8e5

(feat) add deps and include router

fad0995

matching PR for #7796

81e3d8b

- matching PR for #7796

(feat) add gateway func

8990839

(feat) add gateway router

c74f0e1

(feat) add gateway models

e9e00a7

(feat) adapt routers to include gateway

5482674

(feat) add gateway models and client

c44d415

(feat) remove not necessary endpoint

5eb9eb1

(feat) improve models

1955798

(feat) improve gateway service

9907eb8

(feat) merge network chain

ff5d5f8

(feat) unify on network chain

3f00099

cardosofede and others added 28 commits February 18, 2026 15:29

(feat) add executor logs

e2caf8b

(feat) add executor logs

caee7c3

(feat) update deploy to new hummingbot version

a299744

(feat) add executor log capture

9cb71b4

(feat) update method usage

9681033

Merge feat/update_hummingbot into feat/lp-executor

5850ec1

Resolved conflict in services/executor_service.py by keeping ExecutorLogCapture import

fix: use absolute import for lp_rebalancer to match hummingbot structure

ddb4f96

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Merge pull request hummingbot#128 from hummingbot/feat/update_hummingbot

dbcef3d

Feat/update hummingbot

docs: add bot deployment with development images section

db9dcfc

Document how to deploy bots using development hummingbot images instead of the default :latest tag. Co-Authored-By: Claude Opus 4.5 <[email protected]>

Merge pull request hummingbot#120 from hummingbot/feat/lp-executor

3ae1824

feat: add LP executor support

Add function to pull Hummingbot Docker image

8762a8a

Added a function to pull the latest Hummingbot Docker image during setup.

Merge pull request hummingbot#134 from hummingbot/fix/pull-client-image

3edec1f

Add function to pull Hummingbot Docker image

(feat) add controller id to executors

5048918

feat: add controller ID support to executors

d49b71b

Co-Authored-By: Claude Opus 4.6 <[email protected]>

(feat) update method usage

432604f

Merge pull request hummingbot#138 from hummingbot/feat/add_controllerid

7ed0b99

(feat) add controller id to executors

fix: initialize active order timestamps in api trading flows

2090eed

marcuspocus marked this pull request as ready for review April 6, 2026 16:30

marcuspocus changed the base branch from main to development April 13, 2026 11:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: initialize active order timestamps in api trading flows#143

fix: initialize active order timestamps in api trading flows#143
marcuspocus wants to merge 591 commits into
hummingbot:developmentfrom
marcuspocus:fix/active-orders-nan-timestamps

marcuspocus commented Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

marcuspocus commented Apr 6, 2026

Summary

Context

Changes

Validation

Notes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants