Skip to content

Fix CI AssertionError: assert not True #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
albertvillanova merged 1 commit into from
Jan 28, 2026
Merged

Fix CI AssertionError: assert not True #4921

albertvillanova merged 1 commit into from
Jan 28, 2026
+2 −2

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jan 28, 2026 •
edited
Loading

Fix CI AssertionError: assert not True:

  • Set float32 dtype in KTO and PRM tests

Fix #4920.

Follow-up to:

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 28, 2026

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qgallouedec
Copy link
Member

qgallouedec commented Jan 28, 2026 •
edited
Loading

This completes #4778

@albertvillanova albertvillanova merged commit 5461a74 into huggingface:main Jan 28, 2026
2 of 3 checks passed
nenuadrian pushed a commit to nenuadrian/trl that referenced this pull request Feb 1, 2026
@albertvillanova @nenuadrian
Fix CI AssertionError: assert not True (huggingface#4921)
2663693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qgallouedec qgallouedec qgallouedec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI fails for experimental tests: AssertionError: assert not True

3 participants

@albertvillanova @HuggingFaceDocBuilderDev @qgallouedec