Skip to content

Conversation

@albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jan 27, 2026

Fix CI AssertionError: Parameter has not changed:

  • Set float32 dtype in test_training_with_liger_grpo_kernel

Fix #4903.

Follow-up to:

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@albertvillanova
Copy link
Member Author

I have run the test locally and now it passes:

RUN_SLOW=1 pytest ../trl/tests/test_grpo_trainer.py::TestGRPOTrainerSlow::test_training_with_liger_grpo_kernel

=========================================================================================== test session starts ===========================================================================================
platform linux -- Python 3.10.18, pytest-9.0.2, pluggy-1.6.0
rootdir: /fsx/albert/dev/trl
configfile: pyproject.toml
plugins: xdist-3.8.0, anyio-4.12.0
collected 2 items                                                                                                                                                                                         

../trl/tests/test_grpo_trainer.py ..                                                                                                                                                                [100%]

================================================================================ 2 passed

@albertvillanova albertvillanova merged commit 226ef57 into huggingface:main Jan 27, 2026
10 checks passed
nenuadrian pushed a commit to nenuadrian/trl that referenced this pull request Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI fails for slow tests: AssertionError: Parameter model.layers.0.self_attn.q_proj.weight has not changed

3 participants