You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One more thing: these three default values are all quite small. During actual training, it's easy to overlook setting these values, which can lead to errors. Do they need to be increased?
@qgallouedec
these three default values are all quite small. During actual training, it's easy to overlook setting these values, which can lead to errors. Do they need to be increased? @qgallouedec
max_prompt_length and max_completion_length should be removed as part of #3906
these three default values are all quite small. During actual training, it's easy to overlook setting these values, which can lead to errors. Do they need to be increased? @qgallouedec
max_prompt_length and max_completion_length should be removed as part of #3906
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
make dpo compatible with qwen3vl
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.