Skip to content

🚨 [v5] Rename left traces of past_key_value in BERT-like models#41448

Merged
zucchini-nlp merged 1 commit intohuggingface:mainfrom
zucchini-nlp:past-kv-rename
Oct 9, 2025
Merged

🚨 [v5] Rename left traces of past_key_value in BERT-like models#41448
zucchini-nlp merged 1 commit intohuggingface:mainfrom
zucchini-nlp:past-kv-rename

Conversation

@zucchini-nlp
Copy link
Member

What does this PR do?

As per title, finalizes the work from #41425 and renames past_key_value as past_key_values in all files without deprecation cycle

It was a find and replace, so tests might fail 😅

@zucchini-nlp zucchini-nlp requested a review from vasqu October 8, 2025 12:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: autoformer, bart, bert, bert_generation, bigbird_pegasus, biogpt, blenderbot, blenderbot_small, blip, bridgetower, camembert, data2vec, decision_transformer, electra, ernie, flaubert

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, all these big PRs made a mess :o lgtm

Just to be sure, can you check with run slow for the important models (bert, bart, gpt2, t5, roberta)

@zucchini-nlp
Copy link
Member Author

zucchini-nlp commented Oct 9, 2025

Ran slow tests on Bert, BART, Ernie, GPT2, T5 and MusicGen comparing to main branch, all green ✅

@zucchini-nlp zucchini-nlp merged commit 8137dbd into huggingface:main Oct 9, 2025
25 checks passed
@Cyrilvallez
Copy link
Member

Not sure how they got back here because I had definitely made the switch in #39956 already... We need to be very careful when touching a lot of files otherwise we shoot ourselves in the foot!

@zucchini-nlp
Copy link
Member Author

Yep, might be simply issues with rebasing main. Happens a lot when everyone is making huge PRs 😄

@vasqu
Copy link
Contributor

vasqu commented Oct 9, 2025

Yup, sorry that's likely on me with the vLLM refactor 😢 wasn't aware of that rename

AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants