🚨 [v5] Rename left traces of past_key_value in BERT-like models#41448
🚨 [v5] Rename left traces of past_key_value in BERT-like models#41448zucchini-nlp merged 1 commit intohuggingface:mainfrom
past_key_value in BERT-like models#41448Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: autoformer, bart, bert, bert_generation, bigbird_pegasus, biogpt, blenderbot, blenderbot_small, blip, bridgetower, camembert, data2vec, decision_transformer, electra, ernie, flaubert |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
left a comment
There was a problem hiding this comment.
Thanks a lot, all these big PRs made a mess :o lgtm
Just to be sure, can you check with run slow for the important models (bert, bart, gpt2, t5, roberta)
|
Ran slow tests on Bert, BART, Ernie, GPT2, T5 and MusicGen comparing to main branch, all green ✅ |
|
Not sure how they got back here because I had definitely made the switch in #39956 already... We need to be very careful when touching a lot of files otherwise we shoot ourselves in the foot! |
|
Yep, might be simply issues with rebasing main. Happens a lot when everyone is making huge PRs 😄 |
|
Yup, sorry that's likely on me with the vLLM refactor 😢 wasn't aware of that rename |
…ggingface#41448) rename everything
What does this PR do?
As per title, finalizes the work from #41425 and renames
past_key_valueaspast_key_valuesin all files without deprecation cycleIt was a find and replace, so tests might fail 😅