fix: force light theme styles for output tokenids visibility #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate PR #1497 |
Author
|
Thanks for letting me know! I see that PR #[1497] covers this fix. I'll close this one to avoid redundancy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR addresses the visibility issue reported in the Agents Course (Issue #507).
Problem: When the course website is in dark mode, the tokenizer (token_ids) output becomes unreadable due to color inheritance inside the iframe.
Solution: Instead of adding dark mode support, I have forced the output container to remain in "light mode" (white background, black text). This ensures the playground remains consistent and readable regardless of the theme used in the environment where it is embedded.
Changes:
Updated className of the output div in App.jsx to explicitly use bg-white and text-black.