Avoid full vocab clone in get_vocab_size()#2074
Open
eunseo9311 wants to merge 1 commit into
Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
59d1e77 to
0fa29b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_vocab_size(true)was callingget_vocab(true).len(), which clones the entire model vocabulary into a newHashMapjust to count entries.For large vocabularies (e.g. LLaMA-3 128k tokens) this allocates ~10MB on every call.
Fix by computing
base + added.len() - overlappingdirectly, whereoverlappingcounts added tokens already present in the model viatoken_to_id. Zero allocation.Applies the same fix to the Node binding, which had the identical pattern.
Adds a test covering the overlap scenario (token in both model vocab and added_vocabulary).