fix: extend retry predicate to cover transient server errors and connection failures#2186
Open
VANDRANKI wants to merge 1 commit intohuggingface:mainfrom
Open
fix: extend retry predicate to cover transient server errors and connection failures#2186VANDRANKI wants to merge 1 commit intohuggingface:mainfrom
VANDRANKI wants to merge 1 commit intohuggingface:mainfrom
Conversation
…/504/500) and connection failures Closes huggingface#2165
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #2165
ApiModelalready has retry logic viaRetrying, but the predicateis_rate_limit_erroronly matches 429 / rate-limit signals. Transient server errors (502, 503, 504, 500) and connection failures (reset, timeout) are not retried today — the agent run fails immediately even though a retry would succeed.This PR adds
is_transient_error, a broader predicate that covers:Non-retryable errors (400 bad request, 401 unauthorized, 404 not found) are not matched and still fail immediately.
ApiModelnow usesis_transient_erroras its retry predicate. The oldis_rate_limit_erroris kept for backwards compatibility.Tests
Added
TestIsTransientErrorintests/test_models.pywith 11 cases: rate limit variants, each server error code, connection reset, timeout, and three non-retryable codes that must not match.