Separate build data structs from serializations #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have three versions of the build format (v1-3), where we converted prior versions to the latest and used the latest as the actual configuration. The downside of this approach is that every time we introduce a new version, we have to move all utility functions, etc. to the latest. This change decouples the configuration that is used to generate the build files from the concrete serializations. The core data structures move to the top-level module and v1-v3.rs now only contain plain data structures to (de)serialize with serde.
danieldk
force-pushed
the
config-decouple
branch
from
d6b9aaf to
0f11f27
Compare
drbh
approved these changes
Dec 18, 2025
Collaborator
drbh
left a comment
drbh
left a comment
There was a problem hiding this comment.
nice, looks good to me! great improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have three versions of the build format (v1-3), where we converted prior versions to the latest and used the latest as the actual configuration. The downside of this approach is that every time we introduce a new version, we have to move all utility functions, etc. to the latest.
This change decouples the configuration that is used to generate the build files from the concrete serializations. The core data structures move to the top-level module and v1-v3.rs now only contain plain data structures to (de)serialize with serde.