Use Homebrew and Unknown region flags

[NABN00B]

Draws the Free Spreech Flag for (what we detect as) Homebrew and a question mark flag for Internal, Test, Diagnostic tool and Unknown regions. Unknown kind of covers everything that isn't a PSP ISO.

Before merging, we need to consider whether this is needed or wanted at all. Users who play a lot of homebrew might find it annoying.

(In the screenshots I've used the images.svg file supplied at this time from the repo. Size, colors and UI position of the flags may or may not be changed in the future.)

[NABN00B]

Oops, I meant to open this as DRAFT -- there are things to consider.

[NABN00B]

I did have a draft for an icon to be drawn for GE dumps, so as not to recycle the question mark flag everywhere, but because hrydgard hadn't merged that into the svg, I didn't code that.

[hrydgard]

Ah so that's what the teapot was for! Though, a teapot isn't really much related to a game framedump... it's more of a general graphics programming trope.

On another note, not a huge fan of the "free speech flag" aesthetically. Might come up with something different for homebrew...

[NABN00B]

I'm not sure why but the region checks are also run for save data, and for some reason always gets detected as homebrew. Idk why the ID turns into -. I haven't checked the code yet.

Something should be done about this one way or another. I can see several ways this can be solved, depending on what we want.

[hrydgard]

Since some time the problem of savedata showing the homebrew region is gone. Instead, I added a "Save data" overlay to them. Maybe we can device an icon instead... Also now you can press them to get the same dialog as in the save data manager, might be preferrable for some. that's since #21277 .

[NABN00B]

Can I force a new build for this PR somehow?

Instead, I added a "Save data" overlay to them. Maybe we can device an icon instead...

How about a small floppy icon in the place where the user config icon usually is? (Maybe I can cook something on Sunday....)

I'm also considering a helper function to help placing the icons on / next to the game buttons, because the code is a bit messy and currently the offsets depend on the size of the icon, rather than being positioned relatively to the corners / sides, requiring manual change every time the icons are edited.

Also now you can press them to get the same dialog as in the save data manager

That's a pretty neat feature! But it looks like there's a flash when the popup gets cancelled. 👀

[hrydgard]

@NABN00B to force a new build, I assume you mean apply this to the latest version. What you want to do is to rebase your branch on origin/master (after git fetch) and then force-push it. (git push -f)

Floppy, maybe :)

Yeah, it just reloads the listing. Not ideal, ideally it should only refresh if you delete the savedata from the dialog (otherwise nothing changed, so not needed)

[NABN00B]

I think save data getting caught as Homebrew is caused by the game ID getting set to -.