Draft
Conversation
hrydgard
force-pushed
the
https-linux-poc
branch
from
d876877 to
59b077b
Compare
Owner
Author
|
Rebased. Not seeing the slowness I complained about before.. maybe should get it in. |
hrydgard
force-pushed
the
https-linux-poc
branch
from
59b077b to
898bf42
Compare
Owner
Author
|
Rebased this on master. Not sure where the previous bad performance came from, but now it seems to be fine. However, has build errors, I assume we need some cmake/ci magic. Installing the development library fixed all the CI except alpine. Anyway, I'm holding off until post 1.20.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches to using libcurl for https, instead of plain old http.
Works, but very slow for me for some reason.
Remaining work here is to update build instructions, add a proper compile time check for libcurl existence, etc.