[WIP] iOS AltKit support for JIT

[JoeMatt]

refs #14570

Overview

• Add AltKit CMake (currently a custom branch until Add CMake integration altstoreio/AltKit#1 is merged)
• Update Info.plist for bonjour usage string
• Add basic code to connect to AltKit
• Conditionally import AltKit in AppDelegate.mm

Build instructions I'm using;

cmake -DCMAKE_TOOLCHAIN_FILE=./cmake/Toolchains/ios.cmake -DIOS_PLATFORM=OS -DCMAKE_IOS_SDK_ROOT=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk -H. -Bbuild.ios -GXcode

References

jpd002/Play-#1078
https://github.com/jpd002/AltKit/tree/cmake_poc

Todo

• Activate/Disable JIT in PPSSPP on success/failure callbacks
• Fix import AltKit (how to do in CMake?)
• Fix CMake error CMake Error at ext/AltKit/CMakeLists.txt:3 (project): Language 'C' is currently being enabled. Recursive call not allowed.

Discussion

I wanted to test JIT in AltKit for another project, and PPSSPP seemed like a good project to test since I don't have JIT code active in my other project.

I'm a CMake noob, I couldn't figure out the AddLanguage error, so I'm posting this WIP PR to see if anyone else wants to take a stab or give some feedback/help.

Thanks

ping @lonkle

[hrydgard]

Yeah this might be useful for some iOS users. Enabled CI for your account, I'm open to merging this.

[lonkelle]

Wanted to add a note on this PR after working with @JoeMatt today to really follow this entire conversation here: jpd002/Play-#1078 - and the PoC branch's commits of jpd002's Play! app which is the best example of integrating AltKit into a Cmake project: https://github.com/jpd002/AltKit/tree/cmake_poc - we'll make an official Cmake build guide down the road but these are early days.

And if any future devs seeing this want a guide as to when they could or should ask AltServer to enable JIT for the user, you can read my write up here: https://trello.com/c/YNjfbtX2/96-partnerships-create-a-library-for-other-developers-to-use-to-automatically-enable-jit-when-possible

[unknownbrackets]

Currently, ./b.sh --ios uses Make, which apparently isn't supported for Swift:

Swift language not supported by "Unix Makefiles" generator

Generally, ./b.sh is the recommended way to build and also what our CI checks use to make sure other changes don't break iOS, so we'd need to get that working (not sure if using xcodebuild or etc.?)

-[Unknown]

[JoeMatt]

Currently, ./b.sh --ios uses Make, which apparently isn't supported for Swift:

Swift language not supported by "Unix Makefiles" generator

Generally, ./b.sh is the recommended way to build and also what our CI checks use to make sure other changes don't break iOS, so we'd need to get that working (not sure if using xcodebuild or etc.?)

-[Unknown]

I think cmake would be the easier way to go. Would you prefer if I update the CI scripts to work with cmake?

[unknownbrackets]

Well, b.sh just runs CMake for you with the right arguments, but it's going to use Unix Makefiles. It might be okay if it uses -G Xcode, as long as you modify b.sh to do that. It'd be best if this could continue working with CMake without forcing a specific generator.

But yes, either way it would be CMake. We don't include any non-CMake build files for iOS, as far as I know.

-[Unknown]

[JoeMatt]

Well, b.sh just runs CMake for you with the right arguments, but it's going to use Unix Makefiles. It might be okay if it uses -G Xcode, as long as you modify b.sh to do that. It'd be best if this could continue working with CMake without forcing a specific generator.

But yes, either way it would be CMake. We don't include any non-CMake build files for iOS, as far as I know.

-[Unknown]

Noted thanks.

In the meantime, I think I'm pretty much stuck anyway right now.
I have the target building the swift libs and linking them, but the header includes aren't working since its making static-libs not .frameworks and I have no idea how to add the required headers for #import to work in AppDelegate.m