This repository was archived by the owner on May 27, 2025. It is now read-only.
Open
Conversation
reidpr
suggested changes
Mar 5, 2024
Collaborator
reidpr
left a comment
reidpr
left a comment
There was a problem hiding this comment.
Thanks Layton!
A few comments:
-
At this level we want a generic direction called
experiment. Your stuff would then be a sub-directory within that. The goal is that future experiments would then be other sub-directories. -
Increment the storage version. Otherwise, older Charliecloud versions that don’t know about the experiment directory will fail, complaining about unexpected files.
-
Document the directory’s purpose somewhere (possibly
experiment_dir()method?).
…ing head directory for experiments name to just be generic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
lib/filesystem.pyto include an extra directory known asexperiment, which will contain all of the data gathered from the build cache performance experiment.