Add misaligned request check for recorder handler#37
Open
PrasannaPal21 wants to merge 1 commit intohpc-io:masterfrom
Open
Add misaligned request check for recorder handler#37PrasannaPal21 wants to merge 1 commit intohpc-io:masterfrom
PrasannaPal21 wants to merge 1 commit intohpc-io:masterfrom
Conversation
Contributor
Author
|
hello @jeanbez sir, can you please review this implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recorder path had a TODO for checking misaligned requests; the Darshan path already does this via POSIX_FILE_NOT_ALIGNED / POSIX_MEM_NOT_ALIGNED. This adds the same kind of check for recorder by deriving file alignment from offset/size in the POSIX intervals (4K block). When enough ops are misaligned we call the existing check_misaligned() so recorder users get the same recommendation as Darshan.