Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix video streaming when mTLS (client certificate auth) is enabled, particularly for notification video playback and MJPEG streaming, by ensuring the right URLSession/Alamofire delegates are used and that AVFoundation uses custom URL loading when needed.
Changes:
- Add an mTLS-capable Alamofire
SessionDelegatefor MJPEG streaming that also emits the response-boundary notification. - Update
HomeAssistantAPI.VideoStreamer()to select the correct delegate when a client certificate is configured. - Enable AVFoundation custom URL loading for HLS streams when a client certificate is present (in addition to security exceptions).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/Shared/API/MJPEGStreamer.swift | Adds MJPEGCertificateSessionDelegate to combine mTLS handling with MJPEG response notifications. |
| Sources/Shared/API/HAAPI.swift | Chooses MJPEG session delegate based on whether the server has a client certificate configured. |
| Sources/Extensions/NotificationContent/CameraStreamHLSViewController.swift | Enables custom AVURLAsset URL loading when mTLS is configured so auth challenges can be handled. |
Sources/Extensions/NotificationContent/CameraStreamHLSViewController.swift
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4427 +/- ##
=======================================
Coverage ? 42.62%
=======================================
Files ? 265
Lines ? 15577
Branches ? 0
=======================================
Hits ? 6640
Misses ? 8937
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes