Conversation
…prove padding and positioning
|
Installed package locally, it is newer than webawesome's version though https://github.com/home-assistant/webawesome/blob/next/packages/webawesome/package.json#L85 |
|
I feel like floating-ui is a bit of overkill for this, as we dont need to attach it to an element that is moving on screen, or keep the toast on screen, cant we just set the toast itself to a fixed position? |
|
Not without changing the library to force fixed strategy: https://github.com/home-assistant/webawesome/blob/next/packages/webawesome/src/components/popup/popup.ts?rgh-link-date=2026-03-26T10%3A45%3A02Z#L434 |
|
We are not using popup anymore now right? |
In dev we are yeah. Unless you mean |
|
I mean for the toast |
dd83e61 to
3c343f9
Compare
|
Tried the strategy fixed change on the lib, that made things worse screenrecording-2026-03-26_15-34-07.mp4 |
|
Found a better solution using the popover api directly |
|
That won't work in legacy browsers. Is WA using this API too? |
They use this and rely on CSS otherwise for legacy browsers. This is the same for wa-popover usage as they expand wa-popup. I've added a fallback to css for legacy browsers |
nice, can you test it in a legacy browser and confirm that it works? |
|
Windows 10 Chrome 100 (build from 2022, popovers added in 2024): screenRecording-27-3-2026-11-23.mp4Functional, but top layer issue returns. ES5 build uses standard Second test in same build with mobile layout: screenRecording-27-3-2026-11-25.mp4There's a secondary issue here with pickers in the wrong position, but as most desktops are on the new build I would say this is fine. The bottom sheets in mobile are odd also, but these might be browserstack/bad build related, not an es5 issue. Might also try an old mobile device on here |
|
iPad os 18 on safari (seems to class as a modern build): screenRecording-27-3-2026-11-34.mp4 |
|
iPad os 17 screenRecording-27-3-2026-11-44.mp4 |
|
Does it work on iOS 16? (popover was introduced in iOS 17) |
|
macos with 16.5 (versions lower than 16.4 has no support of the ha-input implementation which uses ElementInternals.setValidity()), no ios variant has this patched version screenRecording-27-3-2026-12-3.mp4
There are other flaws with this legacy browser, it might be browserstack related though - Dialogs have no scrim, copy doesnt show at all but toast works in normal views. pickers also have issues with closing outside (scrim) unless using esc or picking an item |



Breaking change
Proposed change
Replaced the
wa-popupwith standard div using the popover API directly. Replicated most of the functionality and fallbacks to CSS (see legacy browser testing below)Adjusted the padding on the toast itself to fit the content a little better (space 2 -> 3 etc)
Screenshots
screenrecording-2026-03-26_16-21-14.mp4
screenrecording-2026-03-26_16-18-40.mp4
Type of change
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed:
To help with the load of incoming pull requests: