Skip to content

Make more info adaptive bottom sheet height match tallest more info dialog#30112

Open
timmo001 wants to merge 2 commits intodevfrom
reduce-adaptive-sheet-more-info-height
Open

Make more info adaptive bottom sheet height match tallest more info dialog#30112
timmo001 wants to merge 2 commits intodevfrom
reduce-adaptive-sheet-more-info-height

Conversation

@timmo001
Copy link
Member

@timmo001 timmo001 commented Mar 12, 2026

Breaking change

Proposed change

Lights with favorites and effects is the tallest I could find.

Original issue in screenshots of #30099

Screenshots

Original screenshots image image image image

Smaller height screens will still max out at 100svh - 48px (header height):
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

To help with the load of incoming pull requests:

@timmo001 timmo001 marked this pull request as ready for review March 12, 2026 09:36
@matthiasdebaat
Copy link
Member

Personally, I prefer it to be full height on mobile so you get a more focused view without distractions from the content behind it.

I’ll start a UX design discussion to explore what the best approach would be.

@timmo001 timmo001 added the Needs UX Items requiring a review from the Home Assistant design team label Mar 12, 2026
@piitaya
Copy link
Member

piitaya commented Mar 12, 2026

Different heights may make it more difficult to close because you don't know where the close button will be. Same for history and settings access.
Also, has we have different view in this dialog, dynamic height will not be optimal.
IMO, if there is top bar, the dialog must be fullscreen screen.

@timmo001
Copy link
Member Author

timmo001 commented Mar 12, 2026

Realistically this would only leave about 10-20% on the tallest of devices, original screenshots are mostly for demonstration

Screenshot image

Also, has we have different view in this dialog, dynamic height will not be optimal.

This is fixed at the same height in this case, the sheet does not shift

I'm not sure on the 100% angle, in the mobile space there are are lot of apps adopting a bottom sheet, I find that I click the empty space and the close button almost the same amount of times, filling the screen would just make this a dialog again

Lets get some more views from the UX board

@matthiasdebaat
Copy link
Member

Created this discussion OpenHomeFoundation/ux-design#18

Please share your thoughts there.

@timmo001 timmo001 force-pushed the reduce-adaptive-sheet-more-info-height branch from 61a5585 to 44529ce Compare March 12, 2026 15:49
@timmo001
Copy link
Member Author

Rebased with center controls change:

Updated screenshots image image image image image

Smaller device

image image image image

@timmo001 timmo001 force-pushed the reduce-adaptive-sheet-more-info-height branch from 44529ce to d7bfd00 Compare March 19, 2026 11:09
…ialog

Lights with favorites and effects is the tallest I could find
@timmo001 timmo001 force-pushed the reduce-adaptive-sheet-more-info-height branch from d7bfd00 to 36581b8 Compare March 24, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Needs UX Items requiring a review from the Home Assistant design team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants