Skip to content

Add improvements to text editor - #8560

Merged
philippjfr merged 6 commits into
mainfrom
improve_texteditor
May 7, 2026
Merged

Add improvements to text editor#8560
philippjfr merged 6 commits into
mainfrom
improve_texteditor

Conversation

@ahuang11

@ahuang11 ahuang11 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a few params, namely:

value_input to differentiate from value

selection to capture what the user is selecting (and potentially have the LLM rewrite that portion)

on_keyup to prevent value from being value_input and to prevent breaking changes; mirrors CodeEditor

How Has This Been Tested?

abcdefgg.mp4

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested all AI-generated content in my PR.
    • I take responsibility for all AI-generated content in my PR.

Tools and Models: Opus 4.7 for planning and implementation

Checklist

  • Tests added and are passing
  • Added documentation

@ahuang11
ahuang11 requested a review from philippjfr April 16, 2026 22:06
@codecov

codecov Bot commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.69%. Comparing base (b69080c) to head (40cc4e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8560      +/-   ##
==========================================
+ Coverage   85.65%   85.69%   +0.03%     
==========================================
  Files         350      350              
  Lines       56200    56244      +44     
==========================================
+ Hits        48139    48196      +57     
+ Misses       8061     8048      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr
philippjfr merged commit 0f7aeb8 into main May 7, 2026
17 of 19 checks passed
@philippjfr
philippjfr deleted the improve_texteditor branch May 7, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants