Skip to content

Chore/rm playground#550

Merged
mattyg merged 4 commits intomainfrom
chore/rm-playground
Feb 20, 2026
Merged

Chore/rm playground#550
mattyg merged 4 commits intomainfrom
chore/rm-playground

Conversation

@mattyg
Copy link
Member

@mattyg mattyg commented Feb 11, 2026

Resolves #548
Resolves holochain/hc-spin#55

Summary by CodeRabbit

  • Documentation

    • Removed references to a development tool from README setup instructions and documentation links.
  • Chores

    • Simplified the network startup script by removing a concurrent command to streamline startup.
    • Updated internal runtime/tooling versions and bumped two crate dependencies to newer development releases.

@coderabbitai
Copy link

coderabbitai bot commented Feb 11, 2026

Warning

Rate limit exceeded

@mattyg has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 18 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

Removed all references and invocations of the deprecated/unsupported hc playground from scaffolded web-app templates and bumped a few Holochain-related version pins in manifest and constants.

Changes

Cohort / File(s) Summary
Web-app template (docs & scripts)
templates/generic/web-app/README.md.hbs, templates/generic/web-app/package.json.hbs
Removed mentions of the hc playground from README and removed the hc playground command from the network script (concurrent startup sequence).
Rust manifest
Cargo.toml
Bumped crate versions: holochain_types and mr_bundle advanced to 0.7.0-dev.*.
Runtime/version constants
src/versions.rs
Updated public string constants: HC_SPIN_VERSION from ^0.700.0-dev.0^0.700.0-dev.1 and HOLOCHAIN_VERSION from 0.7.0-dev.90.7.0-dev.12.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • ThetaSinner
  • matthme
🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The PR title 'Chore/rm playground' is vague and generic, using abbreviated terms that don't clearly convey the specific change (removing playground references from scaffolding templates and updating dependencies). Use a more descriptive title like 'Remove playground references from scaffolding templates' to better communicate the primary change.
Linked Issues check ❓ Inconclusive The PR addresses the primary objective from issue #548 (removing playground references) but incompletely addresses issue #55 (dependency updates appear done but webrtc references are not explicitly verified as removed). Verify that all webrtc subcommand references have been removed per issue #55 requirements and confirm the hc-spin dependency update mentioned in the PR description.
Out of Scope Changes check ❓ Inconclusive The dependency bumps in Cargo.toml (holochain_types and mr_bundle) and version updates in src/versions.rs appear to be supporting changes for the playground removal but lack clear justification in the changeset. Clarify whether the Cargo.toml and src/versions.rs changes are necessary for playground removal or if they represent scope creep; provide rationale in PR description.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/rm-playground

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mattyg mattyg added the ShouldBackport/0.6 Post-merge into the default branch; should be backported to the release branch for version 0.6.x label Feb 11, 2026
@mattyg mattyg marked this pull request as ready for review February 18, 2026 17:17
@mattyg mattyg force-pushed the chore/rm-playground branch from 4bafbcc to bdc57f3 Compare February 18, 2026 17:19
@mattyg mattyg requested a review from a team February 18, 2026 17:19
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@templates/generic/web-app/package.json.hbs`:
- Line 6: Remove the now-unused BOOTSTRAP_PORT environment variable from the
"start" script in templates/generic/web-app/package.json.hbs: delete the
BOOTSTRAP_PORT=$(get-port) fragment from the "start" command so it only sets
AGENTS and calls the network script via {{(package_manager_command "network"
null)}}; also scan for any remaining references to BOOTSTRAP_PORT in related
scripts (e.g., network, launch:happ) and ensure hc-spin usage uses
--bootstrap-url where needed instead of relying on that env var.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@templates/generic/web-app/package.json.hbs`:
- Line 6: The start script in templates/generic/web-app/package.json.hbs
contains dead code setting BOOTSTRAP_PORT=$(get-port); remove that token so the
"start" script becomes just AGENTS=${AGENTS:-2} followed by the existing
package_manager_command invocation (i.e., change the "start" value referenced in
package.json.hbs by removing BOOTSTRAP_PORT=$(get-port) so it reads
AGENTS=${AGENTS:-2} {{(package_manager_command "network" null)}}).

jost-s
jost-s previously approved these changes Feb 18, 2026
ThetaSinner
ThetaSinner previously approved these changes Feb 18, 2026
@mattyg mattyg dismissed stale reviews from ThetaSinner and jost-s via e255e3b February 18, 2026 18:10
@mattyg mattyg force-pushed the chore/rm-playground branch from bdc57f3 to e255e3b Compare February 18, 2026 18:10
@cocogitto-bot
Copy link

cocogitto-bot bot commented Feb 18, 2026

✔️ 605390b...e255e3b - Conventional commits check succeeded.

@mattyg mattyg merged commit da69922 into main Feb 20, 2026
10 checks passed
@mattyg mattyg deleted the chore/rm-playground branch February 20, 2026 17:51
@mattyg mattyg mentioned this pull request Feb 20, 2026
@mattyg mattyg removed the ShouldBackport/0.6 Post-merge into the default branch; should be backported to the release branch for version 0.6.x label Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants