core_types: Update to 2018 edition#2012
Conversation
|
CI is failing because the That leaves two options:
Personally, I prefer the second approach, as it turns code that looks like use serde::{Deserialize, Serialize};
use serde_derive::{Deserialize, Serialize};
#[derive(Deserialize, Serialize)]
struct Foo { /* ... */ }into just use serde::{Deserialize, Serialize};
#[derive(Deserialize, Serialize)]
struct Foo { /* ... */ }I'll be pushing a commit that uses said approach. |
|
The current CI failure seems to be cause by a regression in |
|
I opened TeXitoi/structopt#315. In the meantime, I suggest we mitigate this by adding an unused |
|
As a matter of fact, the breakage in |
48d6e94 to
575c348
Compare
PR summary
This PR
holochain_core_types'sCargo.tomlto use the 2018 edition of Rust (ca02f6c)usedeclarations caused by the changes to namespacing in the 2018 edition (ca02f6c)extern crates because the 2018 edition makes them unneeded (ca02f6c)#[macro_use] extern crates and addsusedeclarations for their macros where needed (88af2fe)Foo<'_>notation in accordance with 2018 edition idioms (575c348)testing/benchmarking notes
N/A
followups
I plan to make more of these for all crates that aren't 2018 in this mono-repo.
changelog
documentation