Adds RenderTo function, to render directly to a writer.#29
Open
drhodes wants to merge 10 commits intohoisie:masterfrom
Open
Adds RenderTo function, to render directly to a writer.#29drhodes wants to merge 10 commits intohoisie:masterfrom
drhodes wants to merge 10 commits intohoisie:masterfrom
Conversation
…n to render directly to a writer. Conflicts: Makefile Readme.md mustache.go mustache_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, I synced to your current master and merged. The pull request should now contain only what's relevant to RenderTo. The diff is much cleaner.
After pushing, I realized that the commit message is not what I wanted, tried git --amend, and pushed again, but the message didn't change the way I expected. Looking further, I found some options referring to git push --force as a fix, however it looks dangerous for pull requests.
If you'd like that message changed, I'll look into some more.