Allow silencing of non-string configuration warnings#8
Merged
hlascelles merged 1 commit intomasterfrom Nov 30, 2022
Merged
Conversation
This adds a new configuration entry, `FIGJAM_SILENCE_STRING_WARNINGS`, which if set to `true`/`true` will silence warnings like `WARNING: Use strings for Figaro configuration. 100 was converted to "100"`. eg: ```yaml FIGJAM_SILENCE_STRING_WARNINGS: true # These will now not cause a warning log lines: FOO: 1 BAR: true ``` `FIGARO_SILENCE_STRING_WARNINGS` is also supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new configuration entry,
FIGJAM_SILENCE_STRING_WARNINGS, which if set totrue/truewill silence warnings likeWARNING: Use strings for Figaro configuration. 100 was converted to "100".eg:
FIGARO_SILENCE_STRING_WARNINGSis also supported.Thanks to @owst for offering this fix in the original Figaro gem: laserlemon/figaro#264