Conversation
himynameisdave
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This appears to include your changes from #29, so I'll go review that one first.
|
i forgot to add the new props on the readme section |
@demetrius-mp Good catch, do you mind adding that here, as well as in #29 ? |
|
ok, ill add them |
|
sorry, i definetly messed up something when doing the branches thing. im new to open source 😅 i think that if you close #29 and merge only this PR, it will be ok, since this PR has the commits from #29. this PR has
|
I'd rather have each of these props included as separate commits (makes it easier to revert if there are any issues, plus I it's a nicer commit history to keep things separated). Please address the final comments in #29 and then we can take a look at this PR :) |
|
ok! |
|
@demetrius-mp same comment as here, sorry! #29 (comment) |
adds suport for inline prop
closes #5