Skip to content

fix: bypass cli_progress wrapper when stdout is not a TTY #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mktwix wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: bypass cli_progress wrapper when stdout is not a TTY #5506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions common/utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,33 @@ function save_firewall() {
function show_progress_window() {
disable_ansii_modes
activate_python_venv
# Non-interactive runs (SSH without PTY, cron, background apply) hang forever in
# cli_progress urwid when wrapped this way. Run the target command directly.
# See https://github.com/hiddify/Hiddify-Manager/issues/5479
if [[ ! -t 1 ]]; then
local -a run_cmd=()
local skip=0
for arg in "$@"; do
if [[ $skip -eq 1 ]]; then
skip=0
continue
fi
case "$arg" in
--log|--title|--subtitle|--regex)
skip=1
;;
--)
;;
*)
run_cmd+=("$arg")
;;
esac
done
bash "${run_cmd[@]}"
exit_code=$?
disable_ansii_modes
return $exit_code
fi
install_pypi_package cli-progress
python -m cli_progress --title "Hiddify Manager" "$@"
exit_code=$?
Expand Down