HHH-9414: Convert MarkerObject to enum for serialization safety#11703
Open
hoyeonyy wants to merge 1 commit intohibernate:mainfrom
Open
HHH-9414: Convert MarkerObject to enum for serialization safety#11703hoyeonyy wants to merge 1 commit intohibernate:mainfrom
hoyeonyy wants to merge 1 commit intohibernate:mainfrom
Conversation
beikov
reviewed
Jan 29, 2026
Member
beikov
left a comment
There was a problem hiding this comment.
I like the change, but the test seems useless to me. I'm not sure why the class was deprecated though as we use it internally. Can you chime in @gavinking?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes HHH-9414 by converting
MarkerObjectfrom class to enum, ensuring singleton identity is preserved across serialization/deserialization.Problem:
Class-based MarkerObject creates new instances when deserialized, breaking
==reference checks in session serialization scenarios (Spring Web Flow, clustered environments).Solution:
Use enum to leverage Java's built-in serialization guarantees for singletons.
Changes
MarkerObjectto enum with 6 constantsFixes https://hibernate.atlassian.net/browse/HHH-9414
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
Please make sure that the following tasks are completed:
Tasks specific to HHH-9414 (Bug):
migration-guide.adocOR check there are no breaking changes