Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2850 +/- ##
==========================================
+ Coverage 78.32% 78.39% +0.07%
==========================================
Files 124 124
Lines 17524 17586 +62
==========================================
+ Hits 13725 13787 +62
Misses 3799 3799 ☔ View full report in Codecov by Sentry. |
1196096 to
ec45d9b
Compare
ec45d9b to
1d5b60f
Compare
Owner
|
工单执行任务配置的是永不超时,执行动作本身不是幂等的也不应该有重试机制,建议通过任务下发时配置禁止重试https://django-q.readthedocs.io/en/latest/configure.html#ack-failures |
Contributor
Author
重试是 django-q的默认行为,没发现可禁用的配置,只是想通过其他方法解决。 |
Contributor
Author
|
再就是“工单状态不正确,禁止执行!”的报错,对于用户来说比较模糊,看不懂。实际上在超时的情况下,任务是还在后台执行。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
q-task对于执行超时的工单,会进行重试。但是在执行函数中,对于不在执行态的工单,会简单的报错,造成工单不断的被q-task重试执行,极易发生执行队列阻塞。
修改内容:在执行工单函数中,对于不正常的工单状态,记录工作流日志(提醒用户检查工单实际执行情况),不报错,避免q-task不断重试。