fix(engine): await dynamic CSS backgrounds before capture#2343
Open
miguel-heygen wants to merge 1 commit into
Open
fix(engine): await dynamic CSS backgrounds before capture#2343miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }; | ||
| const decoded = (root.__hf_css_background_decoded ??= new Set<string>()); | ||
| const urls: string[] = []; | ||
| const urlPattern = /url\(\s*(?:"((?:\\.|[^"])*)"|'((?:\\.|[^'])*)'|([^)'"\s][^)]*?))\s*\)/g; |
| }; | ||
| const decoded = (root.__hf_css_background_decoded ??= new Set<string>()); | ||
| const urls: string[] = []; | ||
| const urlPattern = /url\(\s*(?:"((?:\\.|[^"])*)"|'((?:\\.|[^'])*)'|([^)'"\s][^)]*?))\s*\)/g; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
Feedback source: https://heygen.slack.com/archives/C0BGC335AQY/p1783954331452369
A deterministic delayed-image fixture reproduced the race on published 0.7.56: the first two frames after every row switch captured transparent pixels. With this patch, all 90 frames used the expected row, including boundary frames 16, 31, 46, 61, and 76.
Tests
bun run typecheckinpackages/enginebunx vitest run src/services/frameCapture-*.test.ts(96 tests)