fix(render): recover orphaned browsers before retry#2342
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
On
hyperframes@0.7.56, start a long single-worker render and hard-kill the CLI Node process duringcapture_streaming. Fivechrome-headless-shellprocesses remained alive after five seconds, reparented outside the dead CLI tree. This matches the WSL report where an external 600-second timeout left Chrome children consuming swap.The orphan cleanup introduced for preview in #1039 was never called by the standalone
renderpath. This change reuses that current-user, PPID=1-scoped cleanup at the beginning ofrenderLocal, so the next render automatically recovers from a hard-killed predecessor.Verification
bunx vitest run packages/cli/src/commands/render.test.ts packages/cli/src/utils/orphanCleanup.test.ts(59 passed)git diff --check