Merged
Conversation
Since a Arc<Work> can be obtained from `TASK_LIST`, this would allow the potential mutation of 'owned'-state from other CPUs thereby causing a race condition. Thefore, ensure that the deref of an `Arc<Work>` only permits access to `t_shared`.
hexagonal-sun
force-pushed
the
sched-refactor-part2
branch
from
cb4e9c6 to
11535ad
Compare
hexagonal-sun
force-pushed
the
sched-refactor-part2
branch
from
11535ad to
c499ae4
Compare
Replace `CUR_TASK_PTR` with `ProcessCtx`. This allows differentiation between functions that access process context (take in `ProcessCtx` as a parameter) and those that don't. When creating a new class of scheduleable tasks (softirqs, kthreads), this ensure that those functions cannot call context-sensitive functions.
hexagonal-sun
force-pushed
the
sched-refactor-part2
branch
from
c499ae4 to
aaac9ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sched: Work: deref into Arc rather than
OwnedTaskSince a Arc can be obtained from
TASK_LIST, this would allow thepotential mutation of 'owned'-state from other CPUs thereby causing a
race condition. Thefore, ensure that the deref of an
Arc<Work>onlypermits access to
t_shared.sched: eliminate
CUR_TASK_PTRReplace
CUR_TASK_PTRwithProcessCtx. This allows differentiationbetween functions that access process context (take in
ProcessCtxas aparameter) and those that don't.
When creating a new class of scheduleable tasks (softirqs, kthreads),
this ensure that those functions cannot call context-sensitive
functions.