Retain CPU affinity when rescheduling#261
Merged
hexagonal-sun merged 1 commit intohexagonal-sun:masterfrom Mar 18, 2026
Merged
Conversation
hexagonal-sun
requested changes
Mar 15, 2026
| CpuId::from_value((least_tasked_cpu_info & 0xffff) as usize) | ||
| let r = 0..ArchImpl::cpu_count(); | ||
| r.min_by(|&x, &y| { | ||
| // TODO: Find a way to calculate already assigned affinities and account for that |
Owner
There was a problem hiding this comment.
Yeah, this is complicated since runqueues no longer own the tasks that they are waiting on . I suspect we'll end up using some kind of atomic count.
arihant2math
force-pushed
the
retain-cpu-affin
branch
2 times, most recently
from
6fc8ce1 to
647a79e
Compare
arihant2math
force-pushed
the
retain-cpu-affin
branch
from
647a79e to
c2dba97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent cache invalidation. Task stealing should be easy to implement once an algorithm is in place.
Also the weird static logic has been replaced with a shared per cpu struct for simplicity (also because in the future it'd be good to prefer CPUs that share the same L3 cache/numa node/etc.).