Open
Conversation
dzuelke
requested changes
Mar 16, 2022
Contributor
There was a problem hiding this comment.
Can you please change the timeout default value to 2500, do an arithmetic operation to divide by 100, and adjust the help output to say -t <timeout> Startup timeout for launched processes (in ms), also mentioning the default value? Providing the timeout as a count is pretty unintuitive.
dzuelke
force-pushed
the
develop
branch
3 times, most recently
from
f4f3a59 to
9c96009
Compare
dzuelke
force-pushed
the
develop
branch
4 times, most recently
from
b0ccdbe to
33dd3fd
Compare
dzuelke
force-pushed
the
develop
branch
2 times, most recently
from
e8d8573 to
cbec282
Compare
dzuelke
force-pushed
the
develop
branch
2 times, most recently
from
4fbc4d4 to
3a646bc
Compare
dzuelke
force-pushed
the
develop
branch
3 times, most recently
from
a19576c to
89eebc4
Compare
dzuelke
force-pushed
the
develop
branch
5 times, most recently
from
e1bb242 to
58ff19d
Compare
Contributor
|
Bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php-fpm take more than 2500 ms to start when Datadog appsec is enabled. This change add an optional parameter to configure this timeout.