HIRO-158 Add DebugUnenroll to the interface. Implemented in Hiro-GDK#146
Open
rafalgolarz wants to merge 2 commits intomainfrom
Open
HIRO-158 Add DebugUnenroll to the interface. Implemented in Hiro-GDK#146rafalgolarz wants to merge 2 commits intomainfrom
rafalgolarz wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new debug function to unenroll users from event leaderboard cohorts, supporting the HIRO-GDK implementation.
Changes:
- Added
RPC_ID_EVENT_LEADERBOARD_DEBUG_UNENROLLRPC endpoint with ID 126 - Introduced
EventLeaderboardDebugUnenrollRequestmessage structure - Extended
EventLeaderboardsSysteminterface withDebugUnenrollmethod
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| hiro.proto | Adds RPC definition and request message for debug unenroll functionality |
| event_leaderboards.go | Extends interface with DebugUnenroll method signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RPC_ID_EVENT_LEADERBOARD_DEBUG_FILL = 60 [(input) = "", (output) = "EventLeaderboard"]; | ||
| // DEBUG. Assign random scores within a given range to users within the caller's cohort, except for the caller themselves. | ||
| RPC_ID_EVENT_LEADERBOARD_DEBUG_RANDOM_SCORES = 61 [(input) = "EventLeaderboardDebugRandomScoresRequest", (output) = "EventLeaderboard"]; | ||
| // DEBUG. Unenroll from an event leaderboard cohort. |
There was a problem hiding this comment.
The RPC ID 126 appears out of sequence. Previous debug RPC IDs are 60 and 61, but this new one jumps to 126. Consider using the next sequential ID (62) or document why 126 was chosen to avoid confusion about the numbering scheme.
Suggested change
| // DEBUG. Unenroll from an event leaderboard cohort. | |
| // DEBUG. Unenroll from an event leaderboard cohort. | |
| // NOTE: ID 126 is intentionally non-sequential to preserve existing RPC numbering and must not be renumbered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a dependency for HIRO-GDK implementaion in PR: https://github.com/heroiclabs/hiro-gdk/pull/492