Skip to content

chore(vm,stats): fix warnings about paradox struct visibilities#1265

Closed
fogti wants to merge 1 commit intohermit-os:mainfrom
fogti:fix-paradox-vis
Closed

chore(vm,stats): fix warnings about paradox struct visibilities#1265
fogti wants to merge 1 commit intohermit-os:mainfrom
fogti:fix-paradox-vis

Conversation

@fogti
Copy link
Contributor

@fogti fogti commented Feb 17, 2026

These are present in public VM API, and rust/cargo constantly complain about them (non-public item used in public item, essentially).

@fogti fogti added the rust Pull requests that update Rust code label Feb 17, 2026
Copy link
Member

@n0toose n0toose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this after a toolchain update earlier today but ignored it for starters, thanks!

@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.58%. Comparing base (21daf60) to head (5e31ee1).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1265      +/-   ##
==========================================
- Coverage   77.90%   77.58%   -0.32%     
==========================================
  Files          26       26              
  Lines        3824     3824              
==========================================
- Hits         2979     2967      -12     
- Misses        845      857      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jounathaen
Copy link
Member

So I'm not sure if this is a good fix. To me it reads like clippy doesn't understand the sealed-trait pattern, or we are using the sealed trait pattern incorrectly. An #[allow(private_interfaces)] might be the more appropriate solution here.
Anyway, this only occurs on nightly, so I'd suggest postponing this until we hit the issue on stable Rust.

@fogti
Copy link
Contributor Author

fogti commented Feb 25, 2026

Doesn't appear to be present in beta rustc, post-poned for now.

@fogti fogti closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants