chore(vm,stats): fix warnings about paradox struct visibilities#1265
chore(vm,stats): fix warnings about paradox struct visibilities#1265fogti wants to merge 1 commit intohermit-os:mainfrom
Conversation
n0toose
left a comment
There was a problem hiding this comment.
I noticed this after a toolchain update earlier today but ignored it for starters, thanks!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
- Coverage 77.90% 77.58% -0.32%
==========================================
Files 26 26
Lines 3824 3824
==========================================
- Hits 2979 2967 -12
- Misses 845 857 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So I'm not sure if this is a good fix. To me it reads like clippy doesn't understand the sealed-trait pattern, or we are using the sealed trait pattern incorrectly. An |
|
Doesn't appear to be present in |
These are present in public VM API, and rust/cargo constantly complain about them (non-public item used in public item, essentially).