Workspace trust prompt improvements#15592
Workspace trust prompt improvements#15592TheGLander wants to merge 2 commits intohelix-editor:masterfrom
Conversation
d71a9b8 to
dd14c72
Compare
the-mikedavis
left a comment
There was a problem hiding this comment.
This looks like a nice improvement, both not showing the prompt unless it's required and being able to block config but implicitly trust language servers 👍
I just have an opinion on the config
That could be extended so that if That might be better for a follow-up PR, to keep this scoped.
The title of my PR is very ambiguous 😅. I'll change it |
dd14c72 to
759fcc5
Compare
|
Merged Also, yeah, I think it would make sense for conditional LS trust check to be a separate PR because it looks like it'd require some changes to how language server are loaded? |
|
It makes no sense for the config variable to be called |
759fcc5 to
026c7d2
Compare
|
Renamed the option to |
026c7d2 to
e00f5d1
Compare
Introduces some improvements to how workspace trust prompt is handled:
editor.insecure-lspconfig option, which allows LSPs to start, without loading local configseditor.insecure-lspenabled, you will only ever see the prompt when there are local configseditor.insecureandeditor.insecure-lspin config reference and the trust promptThese changes are unrelated to #15582