Skip to content

Workspace trust prompt improvements#15592

Open
TheGLander wants to merge 2 commits intohelix-editor:masterfrom
TheGLander:workspace-trust-improve
Open

Workspace trust prompt improvements#15592
TheGLander wants to merge 2 commits intohelix-editor:masterfrom
TheGLander:workspace-trust-improve

Conversation

@TheGLander
Copy link
Copy Markdown

@TheGLander TheGLander commented Apr 6, 2026

Introduces some improvements to how workspace trust prompt is handled:

  • Added editor.insecure-lsp config option, which allows LSPs to start, without loading local configs
  • Disabled showing the trust prompt for when there's nothing we need trust for. This means that if you have editor.insecure-lsp enabled, you will only ever see the prompt when there are local configs
  • Documented editor.insecure and editor.insecure-lsp in config reference and the trust prompt

These changes are unrelated to #15582

@TheGLander TheGLander changed the title Workspace trust improvements Workspace trust prompt improvements Apr 6, 2026
@TheGLander TheGLander force-pushed the workspace-trust-improve branch from d71a9b8 to dd14c72 Compare April 6, 2026 16:36
Copy link
Copy Markdown
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice improvement, both not showing the prompt unless it's required and being able to block config but implicitly trust language servers 👍

I just have an opinion on the config

@Rudxain
Copy link
Copy Markdown
Contributor

Rudxain commented Apr 7, 2026

This means that if you have editor.insecure-lsp enabled, you will only ever see the prompt when there are local configs

That could be extended so that if insecure-lsp is disabled, Helix only prompts when it's going to auto-start a LS. This is useful because some people only have a handful of LSs installed.

That might be better for a follow-up PR, to keep this scoped.

unrelated to #15582

The title of my PR is very ambiguous 😅. I'll change it

@TheGLander TheGLander force-pushed the workspace-trust-improve branch from dd14c72 to 759fcc5 Compare April 7, 2026 17:59
@TheGLander
Copy link
Copy Markdown
Author

TheGLander commented Apr 7, 2026

Merged editor.insecure and editor.insecure-lsp into one string option, as requested. Also fixed an oversight where the prompt wouldn't be shown if language servers are disabled and there're local configs, due to me not removing the now-obsolete language server check.

Also, yeah, I think it would make sense for conditional LS trust check to be a separate PR because it looks like it'd require some changes to how language server are loaded?

@David-Else
Copy link
Copy Markdown
Contributor

It makes no sense for the config variable to be called insecure anymore now it can hold the value of none, lsp, or all. I think it should be workspace-trust-level. You can then remove the redundant The level of trust every workspace is given. from the docs.

@TheGLander TheGLander force-pushed the workspace-trust-improve branch from 759fcc5 to 026c7d2 Compare April 10, 2026 13:40
@TheGLander
Copy link
Copy Markdown
Author

Renamed the option to editor.workspace-trust-level as requested

@TheGLander TheGLander force-pushed the workspace-trust-improve branch from 026c7d2 to e00f5d1 Compare April 10, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants