-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use svg badge #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use svg badge #1860
Conversation
Additionally: - Use https where possible - Fix 404s to Foundation docs - Remove the link to a legacy example application hosted on Heroku
carlosantoniodasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| For more information see the generator output, our | ||
| [example application code](https://github.com/heartcombo/simple_form-bootstrap) and | ||
| [the live example app](https://simple-form-bootstrap.herokuapp.com/). | ||
| [example application code](https://github.com/heartcombo/simple_form-bootstrap). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been going back-and-forth with removing this, vs trying to get an app up and running somewhere else... even attempted it but ran into weird issues and out of time to try further, so I guess I'll just bite the bullet and remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm successfully using render at the moment, but it appears that they are fingerprinting urls now :(
Did you try that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Yes I did try render, and I ran into a few different issues, fixed them as I went, but the last one was this with assets precompile:
JSON::ParserError: unexpected character: '::render::starttraceinternal::in' at line 1 column 1 (JSON::ParserError)
Which led me to run out of the 512mb memory limit on the free instance when accessing the app 😅 , presumably because it was trying to compile the assets during the request. Anyway, I ran out of time and need to circle back on it, continue on render or try somewhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of unexpected, https://github.com/diowa/ruby3-rails7-bootstrap-heroku is deployed on render with a far-from-being-lightweight asset pipeline: node + shakapacker + webpack
I would like to take a look on the other repo during the weekend (without guarantees)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to take a look at tagliala/simple_form-bootstrap#1
Test deploy: https://simple-form-bootstrap-test.onrender.com/examples/vertical
Three things should be done on Render:
- Remove "test" from the service name to generate
simple-form-bootstrap - Autogenerate secret key
- Autogenerate (or disable) rails master key (useless)
Additionally:
Before
After