Fix: Edit previous votes bug failling to load all photos and resolve performance issue#394
Open
ademolaomosanya wants to merge 6 commits intohatnote:masterfrom
Open
Fix: Edit previous votes bug failling to load all photos and resolve performance issue#394ademolaomosanya wants to merge 6 commits intohatnote:masterfrom
ademolaomosanya wants to merge 6 commits intohatnote:masterfrom
Conversation
ademolaomosanya
changed the title
…h all for ranking Made-with: Cursor
Made-with: Cursor
…note#406) - Add orchestrating workflow (pr.yml) with path-based change detection using dorny/paths-filter, concurrency cancellation, and ci-complete sentinel job for branch protection - Add backend test workflow: builds Docker image, runs pytest on test_web_basic.py, verifies module imports - Add frontend lint workflow: prettier --check, eslint, vite build - Add pytest to dockerfile - Add lint:check and format:check scripts to frontend/package.json - Fix 6 pre-existing ESLint errors: - Remove unused defineComponent import (ViewCampaign.vue) - Remove unused downloadReviews function (RoundInfo.vue) - Remove unused props assignment (RoundView.vue) - Add eslint-disable for multi-word component name (Vote.vue) - Remove unused getCommonsImageUrl imports (VoteEdit.vue, VoteRanking.vue) - Remove pdb.set_trace() calls from test_web_basic.py (would hang CI) - Run prettier --write across frontend/src/ to establish baseline - Delete dead .travis.yml (Python 2.7, Travis CI abandoned)
ademolaomosanya
force-pushed
the
fix/issue-322-edit-votes
branch
from
9d387a7 to
c206d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr fixes #322
Backend - 50 per page default, count=0 returns all (up to 10k), safe count/offset parsing
Frontend - 50 per page with Previous/Next buttons for yesno/rating; ranking loads all in chunks
VoteEdit- loadPage, goPrevPage/goNextPage, lazy loading
i18n- pagination labels (Previous, Next, Page {0})
BEFORE
-no of edits displayed (15)
AFTER
-all edits votes returned with 50 per page