feat: open edit vote in new tab while voting#389
Open
Oyelakin-Mercy wants to merge 1 commit intohatnote:masterfrom
Open
feat: open edit vote in new tab while voting#389Oyelakin-Mercy wants to merge 1 commit intohatnote:masterfrom
Oyelakin-Mercy wants to merge 1 commit intohatnote:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320
This PR wraps the "edit previous vote" buttons in voting rounds (i.e., when jurors are voting) in anchor tags so jurors can right-click them to open rounds in a new tab.
Changes
<a>tags usingrouter.resolveto generate hrefsgetEditHref()helper function to resolve vote-edit route URLs.