feat: add image resolution controller in create new round#386
Open
ItsAbhinavM wants to merge 1 commit intohatnote:masterfrom
Open
feat: add image resolution controller in create new round#386ItsAbhinavM wants to merge 1 commit intohatnote:masterfrom
ItsAbhinavM wants to merge 1 commit intohatnote:masterfrom
Conversation
Contributor
Author
|
I haven't added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #289 and Fixes #323
According to these issues the major concern was the inability to update certain parameters on round creation notably,
min_resolutionandfile_type. I've checked both frontend and backend files for this and came with this conclusion.The backend is perfectly fine as
DEFAULT_ROUND_CONFIGis being updated oncreate_roundfunction and it includes all the parameters includingmin_resolution. So the backend is fine. The only change we need to add was inRoundNewfile and that's what I did.This is how new round looks like:

Database log for

min_resolution