feat(sdk/go): Include a shutdown signaller for closing a client#3331
Draft
gregfurman wants to merge 1 commit intohatchet-dev:mainfrom
Draft
feat(sdk/go): Include a shutdown signaller for closing a client#3331gregfurman wants to merge 1 commit intohatchet-dev:mainfrom
gregfurman wants to merge 1 commit intohatchet-dev:mainfrom
Conversation
|
@gregfurman is attempting to deploy a commit to the Hatchet Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3283
This PR introduces a shutdown utlity that will allow a
Clientto close all pending requests via context cancellation.Since there is no way to cancel a hanging
NewWorkflowrequest without introducing breaking changes, this approach allows us to forcefully stop all requests withclient.Close()Type of change
What's Changed
shutdown.Signallerutility ininternal/shutdown/shutdown.gothat allows us to derive multiple contexts and cancel them when a shutdown call is made.Close() errormethod on theClientinterface, which should ungracefully cancel all currently running requests.