Open
Conversation
214aa41 to
c17000b
Compare
c17000b to
6215e69
Compare
Collaborator
|
Is this a full fix? Hackage rejects not only packages with non-ASCII names, but also packages that contain files with non-ASCII names (in my case, it was an extra-source-files file for the test suite). |
name:name:
Collaborator
Author
|
Emh I misread the issue, let me work on it some more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11197
[ ] Is the change significant? If so, remember to addsignificance: significantin the changelog file.Manual QA
old
cabalwill not complain about non-ASCII chars in package name, newcabalwill.