replace metadata.name "fullname" with "name" in helm-guestbook deployment and service yamls #80
Open
alexsoto-harness wants to merge 7 commits intoharness-community:masterfrom
Open
replace metadata.name "fullname" with "name" in helm-guestbook deployment and service yamls #80alexsoto-harness wants to merge 7 commits intoharness-community:masterfrom
alexsoto-harness wants to merge 7 commits intoharness-community:masterfrom
Conversation
* testing HAR artifact * change metadata.name from fullname to name in deployment and service yamls * restore helpers file * back to fullname to test * trunc to 55 to allow for blue/green/stage added after * revert trunc to 63 and to using name instead of fullname for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the example tutorial on: https://developer.harness.io/docs/continuous-delivery/get-started/cd-tutorials/helm-chart?deploymentui=bgui
Deployments were failing due to the deployment & service names being longer than 64 chars. Although the helpers file truncates them to 64 chars, when doing blue/green, Harness adds "-stage/green/blue" to the release name which makes it longer than 64 therefore failing.
By changing metadata.name from "helm-guestbook.fullname" to "helm-guestbook.name" this is avoided