Conversation
GheisMohammadi
marked this pull request as draft
May 28, 2026 14:21
GheisMohammadi
marked this pull request as ready for review
June 3, 2026 17:44
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # internal/params/config.go
Contributor
Merge conflicts resolved in commit |
Frozen
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double-sign slashing already takes validator self-slash debt and total stake from the epoch snapshot, but the external delegator denominator was built by subtracting the validator’s live self-delegation from snapshot total stake. A validator could add self-stake after the snapshot and before slash settlement without increasing their own slash debt, while shrinking the external denominator and pushing disproportionate losses onto outside delegators (and inflating the slash beneficiary payout when those debts are capped to available balances).
This change aligns the denominator with the snapshot:
totalExternalStakeis computed as snapshot total stake minus snapshot self-stake, matching the snapshot amounts used inmakeSlashListand in each external delegator’s slash share. Validator slashing still runs against current delegations so balances andundelegationsreflect live state; only the proportional split for externals is corrected.