✨ feat(mq-lint): add auto-fix support to 9 lint rules and --fix/quick-fix#1973
Merged
Conversation
…-fix
Introduces mq_lint::Fix (single/composed literal-or-verbatim replacements
resolved lazily against source text) and wires it through mq-lint's new
--fix CLI flag and mq-lsp's code action quick fixes. Makes boolean_comparison,
redundant_try, unnecessary_interpolation, prefer_let_over_var,
redundant_boolean_literal, unused_variable, unused_parameter,
constant_string_concat, and prefer_coalesce auto-fixable.
Also fixes unused_variable/unused_parameter false positives (and would-be
unsafe fixes) on names only referenced via `${x}` string interpolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces mq_lint::Fix (single/composed literal-or-verbatim replacements resolved lazily against source text) and wires it through mq-lint's new --fix CLI flag and mq-lsp's code action quick fixes. Makes boolean_comparison, redundant_try, unnecessary_interpolation, prefer_let_over_var, redundant_boolean_literal, unused_variable, unused_parameter, constant_string_concat, and prefer_coalesce auto-fixable.
Also fixes unused_variable/unused_parameter false positives (and would-be unsafe fixes) on names only referenced via
${x}string interpolation.Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context