Add TEXTJOIN function#1625
Open
marcin-kordas-hoc wants to merge 5 commits intohandsontable:developfrom
Open
Conversation
* Fix package-lock file * Docs: remove CodeSandbox embedded demos and add links to working exa,ples in Stackblitz (handsontable#1621)
- Remove dead code: redundant CellError check after coerceScalarToString in flattenArgToStrings - Remove empty no-op afterEach callback from textjoin test suite
Per code review: smoke.spec.ts should stay minimal. All TEXTJOIN tests are now consolidated in textjoin.spec.ts, covering individual cell references, single-ref args, and explicit empty-string vs null cell behaviour for ignore_empty=TRUE/FALSE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TEXTJOIN(delimiter, ignore_empty, text1, [text2, …])inTextPluginignore_emptyisTRUE; includes them whenFALSE#VALUE!when the result exceeds 32,767 characters (Excel cell limit)ErrorMessage.TextJoinResultTooLongfor the length-exceeded errordocs/guide/built-in-functions.mdTest plan
test/textjoin.spec.tscovering basic usage,ignore_emptybehaviour, array/range delimiters with cycling, type coercion, error propagation, and edge casestest/smoke.spec.tsinclude TEXTJOIN scenariosnpm run test:jest)npm run compile)npm run lint)Note
Medium Risk
Adds a new core formula function in the interpreter (
TEXTJOIN) with range handling, delimiter cycling, and a new #VALUE! error path, which could affect calculation behavior in edge cases. Changes are additive and well-covered by new unit/smoke tests.Overview
Adds support for the
TEXTJOIN(delimiter, ignore_empty, text1, [text2, …])formula, including scalar or range/array delimiters (cycled between joined parts), optional skipping of empty strings, and propagation of cell errors from delimiter/text inputs.Introduces a new
ErrorMessage.TextJoinResultTooLongand returns#VALUE!when the joined result exceeds 32,767 characters. Updates built-in function documentation, addsTEXTJOINtranslations across supported languages, and adds dedicatedTEXTJOINunit tests plus smoke coverage.Written by Cursor Bugbot for commit cfa61b5. This will update automatically on new commits. Configure here.