Update req.h

[ghost]

missing * means hnsd won't compile on openbsd

[pinheadmz]

Man building on openbsd is hard! Finally installed everything I needed and had to run configure like this:

./configure --with-unbound=/usr/local/ CC=egcc

But then I was able to reproduce your error and confirm this branch fixes it:

Making all in uv
(CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh /root/hnsd/missing autoheader)
rm -f src/stamp-h1
touch ./src/config.h.in
cd . && /bin/sh ./config.status src/config.h
config.status: creating src/config.h
  CC       src/hnsd-cache.o
In file included from src/cache.h:10,
                 from src/cache.c:10:
src/req.h:34:27: error: field 'ss' has incomplete type
   struct sockaddr_storage ss;
                           ^~
*** Error 1 in . (Makefile:1076 'src/hnsd-cache.o': @echo "  CC      " src/hnsd-cache.o;egcc -DHAVE_CONFIG_H -I. -I./src  -I.              -...)
*** Error 1 in /root/hnsd (Makefile:1225 'all-recursive': @fail=;  if (target_option=k; case ${target_option-} in  ?) ;;  *) echo "am__make_...)

[pinheadmz]

Hm although this now:

assertion "sa && dst" failed: file "src/addr.c", line 564, function "hsk_sa_to_string"
Abort trap (core dumped)

[ghost]

Yeah I wasn’t able to get past that

…

Sent from my iPhone

On Mar 10, 2021, at 19:20, Matthew Zipkin ***@***.***> wrote:  Hm although this now: assertion "sa && dst" failed: file "src/addr.c", line 564, function "hsk_sa_to_string" Abort trap (core dumped) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[pinheadmz]

Ok we obviously need to fix that before merging. My guess without digging in is that the original code is correct (it's not a pointer to a struct) and the "incomplete type" error means something else. Do you have any spare cycles to keep working on this? If not we can leave this PR open, I'll come back around to it after addressing some other issues.