Skip to content

update openwrt Makefile#100

Open
shalzz wants to merge 1 commit intohandshake-org:masterfrom
shalzz:master
Open

update openwrt Makefile#100
shalzz wants to merge 1 commit intohandshake-org:masterfrom
shalzz:master

Conversation

@shalzz
Copy link
Contributor

@shalzz shalzz commented Oct 6, 2022

This disables compiling with -O2 flag since it breaks cross-compiling with at least the MIPS architecture.

Optimizations should be safe to re-enable when the build is fixed to handle COPTS compile flags correctly.

This disables compiling with -O2 flag since it breaks cross-compiling
with at least the MIPS architecture.

Optimizations should be safe to re-enable when the build is fixed to
handle COPTS compile flags correctly.
@pinheadmz
Copy link
Member

Awesome, thanks so much for this contribution. If possible, can you explain how I could reproduce the issue? (like, do you own a MIPS device or something?). It would be nice of course to keep optimizations even if it means more work to fix the build.

@shalzz
Copy link
Contributor Author

shalzz commented Oct 6, 2022

Awesome, thanks so much for this contribution. If possible, can you explain how I could reproduce the issue? (like, do you own a MIPS device or something?). It would be nice of course to keep optimizations even if it means more work to fix the build.

Yes, I'm build this for a MIPS device when I encounter this issue.
You can reproduce by having at least these in your .config file when building openwrt.

CONFIG_TARGET_ath79=y
CONFIG_TARGET_ath79_generic=y
CONFIG_TARGET_ath79_generic_DEVICE_tplink_archer-a7-v5=y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants