Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a new
release-npm.ymlworkflow, which we can use for releasing hanami-assets to npm in the same way we release our gems, which includes the automatic GitHub release creation and post to our forum.This uses npm trusted publishing, which I've already configured for our Hanami-assets package.
Common logic between the existing release.yml and our new release-npm.yml has been extracted into separate shared actions.
This approach is facilitated by the changes in hanami/hanami-assets-js#43, which ensure all the necessary publishing-related steps are encapsulated within hanami-assets'
package.json, so the release workflow here can just callnpm publishand nothing else.