Fix classification file export omitting empty target values#1512
Open
adamnadolny-wizipisi wants to merge 3 commits into
Open
Fix classification file export omitting empty target values#1512adamnadolny-wizipisi wants to merge 3 commits into
adamnadolny-wizipisi wants to merge 3 commits into
Conversation
Previously the constructor filtered out all entries with null values via Predicates.notNull(), which caused rows with unmapped target values to be silently dropped. The reverse() method is guarded to skip null values since ArrayListMultimap does not accept null keys. Fixes halestudio#959
Write empty string instead of calling .as(String.class) on a null Value when exporting rows with no mapped target value. Fixes halestudio#959
Write empty string instead of calling .as(String.class) on a null Value when exporting rows with no mapped target value. Fixes halestudio#959
adamnadolny-wizipisi
force-pushed
the
fix/classification-export-empty-values-959
branch
from
June 23, 2026 07:46
6312165 to
baaf5e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using "Fill source values with enumeration" in the classification mapping, the resulting CSV/XLS export silently dropped all rows where the target value was not yet mapped. This made it impossible to send a partially-filled classification to an expert for completion.
Root cause: LookupTableImpl constructor filtered out all
ull target values via Predicates.notNull(), so they never reached the export writers.
Fix:
otNull() filter in LookupTableImpl so entries with null target values are preserved in the table.
everse() to skip null values (ArrayListMultimap does not accept null keys).
Fixes #959
Submitted by: The Wroclaw Institute of Spatial Information and Artificial Intelligence
(WIZIPISI — Wrocławski Instytut Zastosowań Informacji Przestrzennej i Sztucznej Inteligencji)