Fix Image.Enlarge keep image size in boundaries#204
Open
jayme-github wants to merge 3 commits intoh2non:masterfrom
Open
Fix Image.Enlarge keep image size in boundaries#204jayme-github wants to merge 3 commits intoh2non:masterfrom
jayme-github wants to merge 3 commits intoh2non:masterfrom
Conversation
Image.Enlarge does not always return an image that fits into the given width and height boundaries. To fix that, imageCalculations() now returns the maximum factor instead if the minimum if no cropping is requested and the desired image is bigger than the source.
Contributor
Author
|
Just discovered that this change does not fix all edge cases. Input of |
greut
reviewed
Nov 3, 2017
| factor = math.Min(xfactor, yfactor) | ||
| } else { | ||
| factor = math.Max(xfactor, yfactor) | ||
| } |
Contributor
There was a problem hiding this comment.
fyi. this is a revert from #198 with an additional check. Might be better, indeed.
Contributor
Author
There was a problem hiding this comment.
Thanks for the hint. Wat was the reason for removing the check in first place?
Contributor
Author
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image.Enlarge does not always return an image that fits into the given
width and height boundaries.
To fix that, imageCalculations() now returns the maximum factor instead
if the minimum if no cropping is requested and the desired image is
bigger than the source.
Im not completely sure with this but I expected
Image.Enlargeto always return images that don't exceed the width and height provided./cc @tback