chore (PHP): Address PHP 8.4 deprecations#633
Closed
CPChiste wants to merge 2 commits intoguzzle:2.8from
Closed
Conversation
Author
|
@GrahamCampbell Good day! This PR addresses some PHP 8.4 deprecations, however I had thought the simplest path forward would be to drop support for PHP < 7.4. Which might make this a better candidate for a 2.9 minor? Let me know what you think, and if any revisions are required. Thank you, Colby |
Member
|
Thanks, but this is not correct. There is no deprecation issue. The deprecated code path is never run on PHP 8.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 added some new deprecations that exist in psr7:2.8:
https://www.php.net/manual/en/function.trigger-error.php
The simplest solution is to drop support for PHP < 7.4 and just allow throwing of exceptions. Unsure if this would require a new 2.9 minor version of psr7, so open to feedback and guidance.